Rename TestDeltaConnectionServer to LocalDeltaConnectionServer in local-server - part 1 #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,20 +28,20 @@ import { | |||
| DebugLogger, | |||
| } from "@microsoft/fluid-server-test-utils"; | |||
| import { configureWebSocketServices} from "@microsoft/fluid-server-lambdas"; | |||
| import { TestReservationManager } from "./testReservationManager"; | |||
| import { LocalReservationManager } from "./localReservationManager"; | |||
There was a problem hiding this comment.
can you add this to breaking? maybe lump it in with the package change section, so it's all together
anthony-murphy
approved these changes
Feb 25, 2020
This was referenced Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338
Renamed TestDeltaConnectionServer and other related classes in local-server with local prefix instead of test since these are used in scenarios other than testing.
A follow up change will update the consumers to use the new name.