procedural data generation for identifiers #15800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
⯅ @fluid-example/bundle-size-tests: +413 Bytes
Baseline commit: dc61930 |
noencke
reviewed
Jun 7, 2023
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
noencke
reviewed
Jun 7, 2023
experimental/dds/tree2/src/test/feature-libraries/editable-tree/mockData.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/editable-tree/editableField.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
noencke
reviewed
Jun 8, 2023
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/contextuallyTyped.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/defaultFieldKinds.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree/mockData.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree/mockData.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/shared-tree/sharedTree.bench.ts
Outdated
Show resolved
Hide resolved
noencke
reviewed
Jun 13, 2023
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/contextuallyTyped.spec.ts
Outdated
Show resolved
Hide resolved
noencke
approved these changes
Jun 13, 2023
connorskees
pushed a commit
to connorskees/FluidFramework
that referenced
this pull request
Jul 19, 2023
## Description This PR refactors functions from `contextuallyTyped.ts` to take in a `context` object containing a `FieldSource` to generate a `FieldGenerator` used to populate missing (but required) fields based on the schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors functions from
contextuallyTyped.tsto take in acontextobject containing an optionalglobalFieldKeySymbol, to allow generation of missing globalFields which can be used for things like identifiers.