Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Temporarily re-add lerna to package.json #16036

Closed
wants to merge 8 commits into from
+1,824 −10
Closed

ci: Temporarily re-add lerna to package.json #16036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9312120
Change pinned lerna version
alexvy86 Jun 16, 2023
e25d629
Revert "Change pinned lerna version"
alexvy86 Jun 16, 2023
43f94b9
Re-add lerna, pin dep before broken version
alexvy86 Jun 16, 2023
edc36cc
Update lockfile
alexvy86 Jun 16, 2023
a2fa78e
Remove pinned version from npx
alexvy86 Jun 16, 2023
da0735b
Ignore version specifier for @octokit/rest override
alexvy86 Jun 16, 2023
ba5c2a0
Formatting
alexvy86 Jun 16, 2023
51a3d77
Pin @octokit/request-error
alexvy86 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build-tools/packages/build-cli/src/commands/generate/bundleStats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class GenerateBundlestats extends BaseCommand<typeof GenerateBund
static flags = {
packageMetadataPath: Flags.file({
description:
"A path to a file containing JSON formatted package metadata. Used for testing. When not provided, the output of `npx lerna@5.6.2 list --all --json` is used.",
"A path to a file containing JSON formatted package metadata. Used for testing. When not provided, the output of `npx lerna list --all --json` is used.",
required: false,
hidden: true,
}),
Expand All @@ -30,7 +30,7 @@ export default class GenerateBundlestats extends BaseCommand<typeof GenerateBund
const flags = this.flags;
const lernaOutput =
flags.packageMetadataPath ??
JSON.parse(execSync("npx lerna@5.6.2 list --all --json").toString());
JSON.parse(execSync("npx lerna list --all --json").toString());

if (!Array.isArray(lernaOutput)) {
this.error("failed to get package information");
Expand Down
2 changes: 1 addition & 1 deletion build-tools/packages/build-tools/src/bumpVersion/bumpVersion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export async function bumpRepo(
monoRepo: MonoRepo,
) => {
return exec(
`npx lerna@5.6.2 version ${repoVersionBump} --no-push --no-git-tag-version -y && npm run build:genver`,
`npx lerna version ${repoVersionBump} --no-push --no-git-tag-version -y && npm run build:genver`,
monoRepo.repoPath,
"bump mono repo",
);
Expand Down
2 changes: 1 addition & 1 deletion build-tools/packages/build-tools/src/bundleSizeAnalysis/collectBundleAnalyses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const smallestAssetSize = 100;
function main() {
// Get all the package locations
const lernaOutput = JSON.parse(
child_process.execSync("npx lerna@5.6.2 list --all --json").toString(),
child_process.execSync("npx lerna list --all --json").toString(),
);
if (!Array.isArray(lernaOutput)) {
throw new Error("failed to get package information");
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
"copyfiles": "^2.4.1",
"danger": "^10.9.0",
"jest": "^26.6.3",
"lerna": "^5.6.2",
"mocha": "^10.2.0",
"prettier": "~2.6.2",
"pretty-quick": "^3.1.3",
Expand Down Expand Up @@ -178,7 +179,8 @@
"@fluidframework/build-tools>npm-package-json-lint@^6.0.0": "~6.3.0",
"@types/react": "17.0.52",
"@types/react-dom": "17.0.18",
"@oclif/core": "~2.4.0"
"@oclif/core": "~2.4.0",
"@octokit/request-error": "<4.0.2"
},
"peerDependencyRules": {
"allowedVersions": {
Expand Down
Loading