refactor(tree): use field cursors in low-level editing API #19009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
⯅ @fluid-example/bundle-size-tests: +295 Bytes
Baseline commit: 66e3067 |
jenn-le
approved these changes
Dec 29, 2023
Co-authored-by: Jenn <jennle@microsoft.com>
daesunp
added a commit
that referenced
this pull request
Jan 3, 2024
## Description This PR unskips the end to end chunk insert op test, as it is now working due to [PR 19009](#19009).
RishhiB
pushed a commit
to RishhiB/FluidFramework-1
that referenced
this pull request
Jan 3, 2024
RishhiB
pushed a commit
to RishhiB/FluidFramework-1
that referenced
this pull request
Jan 3, 2024
## Description This PR unskips the end to end chunk insert op test, as it is now working due to [PR 19009](microsoft#19009).
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
## Description This PR unskips the end to end chunk insert op test, as it is now working due to [PR 19009](#19009).
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
## Description This PR unskips the end to end chunk insert op test, as it is now working due to [PR 19009](#19009).
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
## Description This PR unskips the end to end chunk insert op test, as it is now working due to [PR 19009](#19009).
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to change the signature of
SequenceFieldEditBuilder.insertso that it takes a single cursor in Field mode instead of an array of cursors in Node mode. The rest of the changes flowed from there, trying to strike a balance between making fewer changes to the code and adopting Field-mode cursors in more places as appropriate/convenient.Breaking Changes
This PR changes internal APIs in ways that make old usages potentially incompatible with the new implementation and makes the old implementation potentially incompatible with new usages. No compatibility attempt has been made since it is expected no host application should be depending on these APIs.