-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle location redirection URL error in getSharingInfo call in odsp driver #21277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatgarg
requested review from
a team,
pragya91,
markfields,
agarwal-navin,
tyler-cai-microsoft,
kian-thompson and
rajatch-ff
and removed request for
a team
June 3, 2024 17:30
github-actions
bot
added
base: main
PRs targeted against main branch
area: driver
Driver related issues
area: odsp-driver
labels
Jun 3, 2024
jatgarg
changed the title
Handle location redirection URl in getSharinkgInfo call in odsp driver
Handle location redirection URL error in getSharingInfo call in odsp driver
Jun 3, 2024
pragya91
reviewed
Jun 7, 2024
AndreiZe
reviewed
Jun 10, 2024
AndreiZe
reviewed
Jun 10, 2024
vladsud
reviewed
Jun 12, 2024
vladsud
reviewed
Jun 12, 2024
vladsud
reviewed
Jun 12, 2024
vladsud
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some number of comments, but it would be great for @AndreiZe to sign off too before it gets merged
⯅ @fluid-example/bundle-size-tests: +355 Bytes
Baseline commit: 8f8728f |
AndreiZe
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADO: https://dev.azure.com/fluidframework/internal/_workitems/edit/8006
After a tenant changes their domain, this leads existing workspaces on the Loop app to stop getting sharing link to the newly created pages. This is because after a redirect, the authorization headers are not sent by the browser. And even if were to just retry with the headers set, SharePoint requires for the auth tokens to be generated for that particular domain.
This PR handle causes the browser to not handle the redirect implicitly by supplying the redirect:manual header in the request and handles the redirect by itself. It will successfully, return the share link to the app.
On the load of the same container, we already have resolveWithLocationRedirectionHandling which handles the redirect during load and also signals the app about the new domain.
Now, I am using the common redirect header instead of prefer header for VROOM Apis as getSharingInfo is not a VROOM api. Redirect header works with all APIs.