Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More documentation: expectations from container & component developers. #2156

Merged
merged 4 commits into from
May 13, 2020
Merged

More documentation: expectations from container & component developers. #2156

merged 4 commits into from
May 13, 2020

Conversation

vladsud
Copy link
Contributor

@vladsud vladsud commented May 12, 2020

More visibility into readonly permissions

@vladsud vladsud requested review from tylerbutler and arinwt May 12, 2020 23:34
@vladsud
Copy link
Contributor Author

vladsud commented May 12, 2020

@leeviana, @ruchika-m any chance you can take a look, as well as recommend anything else to add into "expectations" section?

packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂 I think a few more things can be improved (see my suggestions), but overall makes sense!

packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
packages/loader/container-loader/README.md Outdated Show resolved Hide resolved
@vladsud vladsud merged commit 99a4d21 into microsoft:master May 13, 2020
@xjli1972
Copy link

@vladsud : thanks for the update, the new host expectation section is very informative.

@vladsud vladsud deleted the Documentation branch May 16, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants