Remove deprecated inbound and outbound queues on IDeltaManager #22282

jatgarg · 2024-08-21T04:46:27Z

Description

1.) Remove deprecated inbound and outbound queues on IDeltaManager.
2.) Move them to IDeltaManagerFull so that internal Fluid layers can still use it but not the apps.

msfluid-bot · 2024-08-21T05:28:53Z

⯅ @fluid-example/bundle-size-tests: +890 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	463.61 KB	463.77 KB	⯅ +171 Bytes
azureClient.js	562.45 KB	562.71 KB	⯅ +276 Bytes
connectionState.js	724 Bytes	724 Bytes	■ No change
containerRuntime.js	261.86 KB	262 KB	⯅ +150 Bytes
fluidFramework.js	424.82 KB	424.84 KB	⯅ +14 Bytes
loader.js	134.17 KB	134.19 KB	⯅ +19 Bytes
map.js	42.71 KB	42.71 KB	⯅ +7 Bytes
matrix.js	148.32 KB	148.33 KB	⯅ +7 Bytes
odspClient.js	528.29 KB	528.48 KB	⯅ +190 Bytes
odspDriver.js	97.84 KB	97.86 KB	⯅ +21 Bytes
odspPrefetchSnapshot.js	42.81 KB	42.83 KB	⯅ +14 Bytes
sharedString.js	164.17 KB	164.17 KB	⯅ +7 Bytes
sharedTree.js	415.28 KB	415.29 KB	⯅ +7 Bytes
Total Size	3.36 MB	3.36 MB	⯅ +890 Bytes

Baseline commit: 8d47008

Generated by 🚫 dangerJS against 6710b81

alexvy86

Didn't go through the whole thing, just a couple of comments below, and a general comment that I thought we were still holding off on any breaking changes (including to @alpha/@legacy APIs).

packages/common/container-definitions/src/deltas.ts

packages/loader/container-loader/src/loadPaused.ts

jatgarg · 2024-08-21T22:30:41Z

Didn't go through the whole thing, just a couple of comments below, and a general comment that I thought we were still holding off on any breaking changes (including to @alpha/@legacy APIs).

Yeah, I am not going to merge it until it is allowed to make breaking changes, but want to get review/approval so that I can just merge when it is allowed and to know if it is ok to make this change.

packages/common/container-definitions/src/deltas.ts

packages/runtime/container-runtime/src/containerRuntime.ts

jatgarg · 2024-11-05T23:28:45Z

@jason-ha and @Josmithr Please take a look at this PR when you get time. Thanks.

jason-ha

Be sure to update PR description - still says IDeltaManagerInternal

packages/test/test-utils/src/containerUtils.ts

packages/test/test-end-to-end-tests/src/test/containerDirtyFlag.spec.ts

…to queue2

jason-ha · 2024-11-07T00:03:32Z

Two new notes:

We just had another break change break Loop. I would recommend running (rerunning) the Loop integration tests as due diligence.
Please add a change set. Tyler just added a "Legacy API Changes" section so the changeset can target that. (Set "section" to legacy)

anthony-murphy

api changes look good

jatgarg · 2024-11-07T18:28:58Z

Integration pipeline with Loop succeeded for the breaking change: https://dev.azure.com/office/OC/_build/results?buildId=32410848&view=results

.changeset/nice-flies-brake.md

tylerbutler · 2024-11-07T18:31:50Z

packages/framework/fluid-static/package.json

+		"broken": {
+			"Interface_IFluidContainerInternal": {
+				"backCompat": false
+			}
+		},


I'm very naive - is this safe? cc: @ChumpChief

The breaking changes will have these. However, since we first deprecated it and now properly removing it, then it is fine.

Co-authored-by: Tyler Butler <tyler@tylerbutler.com>

github-actions · 2024-11-07T18:47:58Z

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> fluidframework-docs@0.25.0 ci:start
> http-server ./public --port 1313 --silent


> fluidframework-docs@0.25.0 linkcheck:full
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/tree-start/
- (3430:89) 'here' => https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md (HTTP 404)


Stats:
  443676 links
    3413 destination URLs
       2 URLs ignored
       0 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

Josmithr · 2024-11-07T19:07:45Z

.changeset/nice-flies-brake.md

+
+The inbound and outbound properties have been removed from IDeltaManager
+
+The inbound and outbound properties were deprecated in a previous release and have been removed from IDeltaManager. Please check pull request [#19636](https://github.com/microsoft/FluidFramework/pull/19636) for alternative APIs.


I would recommend including the migration / replacement API instructions directly here, rather than linking to a PR / release notes. That's a lot of navigation steps for our users to jump through to get the information they need.

Will paste here. I added link to the release notes as well. But I can certainly copy those here.

Josmithr

Left a small changeset recommendation, but otherwise docs changes look good.

jatgarg · 2024-11-07T19:53:16Z

Will make the change in another PR. Auto merge was on, so it got merged.

…anager (#23024) ## Description Add chngeset for removing the inbound and outbound queues on iDeltamanager. Refer to this PR for extra details: #22282 --------- Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local> Co-authored-by: Tyler Butler <tyler@tylerbutler.com>

Remove deprecated inbound and outbound queues on IDeltaManager

f345f58

jatgarg self-assigned this Aug 21, 2024

jatgarg requested review from a team as code owners August 21, 2024 04:46

jatgarg marked this pull request as draft August 21, 2024 04:46

jatgarg requested review from a team, pragya91, markfields, tyler-cai-microsoft, kian-thompson and rajatch-ff and removed request for a team August 21, 2024 04:47

alexvy86 reviewed Aug 21, 2024

View reviewed changes

packages/common/container-definitions/src/deltas.ts Outdated Show resolved Hide resolved

packages/loader/container-loader/src/loadPaused.ts Outdated Show resolved Hide resolved

Jatin Garg added 3 commits August 21, 2024 12:02

pr sugg

6b1d9b8

pr sugg

43cb01d

pr sugg

6c40c0f

jatgarg requested review from alexvy86 and vladsud August 21, 2024 22:30

vladsud reviewed Aug 27, 2024

View reviewed changes

packages/common/container-definitions/src/deltas.ts Show resolved Hide resolved

vladsud reviewed Aug 27, 2024

View reviewed changes

packages/runtime/container-runtime/src/containerRuntime.ts Outdated Show resolved Hide resolved

github-actions bot added area: build Build related issues area: contributor experience labels Oct 23, 2024

Jatin Garg added 2 commits November 4, 2024 15:28

merge conflict

8c47df1

add

e1a17ab

jatgarg requested review from Josmithr and jason-ha November 4, 2024 23:39

merge conflict

34fafda

jason-ha approved these changes Nov 6, 2024

View reviewed changes

packages/test/test-utils/src/containerUtils.ts Outdated Show resolved Hide resolved

packages/test/test-utils/src/containerUtils.ts Outdated Show resolved Hide resolved

packages/test/test-end-to-end-tests/src/test/containerDirtyFlag.spec.ts Outdated Show resolved Hide resolved

Jatin Garg added 2 commits November 6, 2024 15:27

Merge branch 'main' of https://github.com/microsoft/FluidFramework in…

dc038dc

…to queue2

pr sugg

37c5589

add changeset

355cfcc

jatgarg requested a review from a team as a code owner November 7, 2024 00:52

github-actions bot added the changeset-present label Nov 7, 2024

anthony-murphy approved these changes Nov 7, 2024

View reviewed changes

tylerbutler reviewed Nov 7, 2024

View reviewed changes

.changeset/nice-flies-brake.md Outdated Show resolved Hide resolved

tylerbutler reviewed Nov 7, 2024

View reviewed changes

jatgarg and others added 2 commits November 7, 2024 10:40

Update .changeset/nice-flies-brake.md

d07babf

Co-authored-by: Tyler Butler <tyler@tylerbutler.com>

fix changeset

6710b81

jatgarg enabled auto-merge (squash) November 7, 2024 19:03

Josmithr reviewed Nov 7, 2024

View reviewed changes

Josmithr approved these changes Nov 7, 2024

View reviewed changes

jatgarg merged commit 45a5769 into microsoft:main Nov 7, 2024
44 checks passed

github-actions bot mentioned this pull request Nov 7, 2024

Upcoming Release: FluidFramework v2.20.0 #22101

Open

jatgarg mentioned this pull request Nov 7, 2024

Add changeset for removing the inbound and outbound queues on IDeltaManager #23024

Merged

jatgarg deleted the queue2 branch November 7, 2024 23:04

github-actions bot mentioned this pull request Nov 7, 2024

Upcoming Release: FluidFramework v2.20.0 tylerbutler/FluidFramework#26

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated inbound and outbound queues on IDeltaManager #22282

Remove deprecated inbound and outbound queues on IDeltaManager #22282

jatgarg commented Aug 21, 2024 •

edited

Loading

msfluid-bot commented Aug 21, 2024 •

edited

Loading

alexvy86 left a comment

jatgarg commented Aug 21, 2024

jatgarg commented Nov 5, 2024

jason-ha left a comment

jason-ha commented Nov 7, 2024

anthony-murphy left a comment

jatgarg commented Nov 7, 2024

tylerbutler Nov 7, 2024

jatgarg Nov 7, 2024

github-actions bot commented Nov 7, 2024

Josmithr Nov 7, 2024 •

edited

Loading

jatgarg Nov 7, 2024

Josmithr left a comment

jatgarg commented Nov 7, 2024


		The inbound and outbound properties have been removed from IDeltaManager

		The inbound and outbound properties were deprecated in a previous release and have been removed from IDeltaManager. Please check pull request [#19636](https://github.com/microsoft/FluidFramework/pull/19636) for alternative APIs.

Remove deprecated inbound and outbound queues on IDeltaManager #22282

Remove deprecated inbound and outbound queues on IDeltaManager #22282

Conversation

jatgarg commented Aug 21, 2024 • edited Loading

Description

msfluid-bot commented Aug 21, 2024 • edited Loading

alexvy86 left a comment

Choose a reason for hiding this comment

jatgarg commented Aug 21, 2024

jatgarg commented Nov 5, 2024

jason-ha left a comment

Choose a reason for hiding this comment

jason-ha commented Nov 7, 2024

anthony-murphy left a comment

Choose a reason for hiding this comment

jatgarg commented Nov 7, 2024

tylerbutler Nov 7, 2024

Choose a reason for hiding this comment

jatgarg Nov 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2024

linkcheck output

Josmithr Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

jatgarg Nov 7, 2024

Choose a reason for hiding this comment

Josmithr left a comment

Choose a reason for hiding this comment

jatgarg commented Nov 7, 2024

jatgarg commented Aug 21, 2024 •

edited

Loading

msfluid-bot commented Aug 21, 2024 •

edited

Loading

Josmithr Nov 7, 2024 •

edited

Loading