build(client-presence): type and lint fixes

[jason-ha]

Minor production runtime changes with introduction of getOrCreateRecord helper and retyping of Object.entries/keys utilities.

[msfluid-bot]

Code Coverage Summary

↓ packages.framework.presence.src:
Line Coverage Change: -1.21%    Branch Coverage Change: -0.63%

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	88.57%	87.94%	↓ -0.63%
Line Coverage	73.96%	72.75%	↓ -1.21%

---

Baseline commit: eac1018
Baseline build: 309591
Happy Coding!!

Code coverage comparison check failed!!
More Details: Readme

• Skip This Check!!

What to do if the code coverage check fails:

• Ideally, add more tests to increase the code coverage for the package(s) whose code-coverage regressed.

• If a regression is causing the build to fail and is due to removal of tests, removal of code with lots of tests or any other valid reason, there is a checkbox further up in this comment that determines if the code coverage check should fail the build or not. You can check the box and trigger the build again. The test coverage analysis will still be done, but it will not fail the build if a regression is detected.

• Unchecking the checkbox and triggering another build should go back to failing the build if a test-coverage regression is detected.

• You can check which lines are covered or not covered by your tests with these steps:

  • Go to the PR ADO build.
  • Click on the link to see its published artifacts. You will see an artifact named codeCoverageAnalysis, which you can expand to reach to a particular source file's coverage html which will show which lines are covered/not covered by your tests.
  • You can also run different kind of tests locally with :coverage tests commands to find out the coverage.

[jason-ha]

Code Coverage Summary

↓ packages.framework.presence.src:
Line Coverage Change: -1.21%    Branch Coverage Change: -0.63%
Baseline commit: 5abfa01 Baseline build: 308954 Happy Coding!!

Code coverage comparison check failed!!

Disabling the code coverage comparison check as it is counting comments and types for coverable lines and erroneously finding a coverage regression.

[msfluid-bot]

⯅ @fluid-example/bundle-size-tests: +245 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	467.26 KB	467.3 KB	⯅ +35 Bytes
azureClient.js	564.03 KB	564.08 KB	⯅ +49 Bytes
connectionState.js	724 Bytes	724 Bytes	■ No change
containerRuntime.js	263.45 KB	263.47 KB	⯅ +14 Bytes
fluidFramework.js	429.04 KB	429.05 KB	⯅ +14 Bytes
loader.js	134.18 KB	134.19 KB	⯅ +14 Bytes
map.js	42.71 KB	42.71 KB	⯅ +7 Bytes
matrix.js	150.15 KB	150.16 KB	⯅ +7 Bytes
odspClient.js	530.63 KB	530.68 KB	⯅ +49 Bytes
odspDriver.js	98.65 KB	98.67 KB	⯅ +21 Bytes
odspPrefetchSnapshot.js	43.04 KB	43.05 KB	⯅ +14 Bytes
sharedString.js	166.23 KB	166.24 KB	⯅ +7 Bytes
sharedTree.js	419.49 KB	419.5 KB	⯅ +7 Bytes
Total Size	3.38 MB	3.38 MB	⯅ +245 Bytes

---

Baseline commit: eac1018

Generated by 🚫 dangerJS against 9fb977a

[RishhiB]

should these helpers be migrated to core-utils?

[jason-ha]

Maybe. I don't like to pre-emptively place utilities in a shared space without more than one use. Certainly, consider if these are generally useful as you look at fixing things. If they are, then we refactor.

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors

[WillieHabi]

Looks good to me