Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate:releaseNotes): Include changesets with no packages in release notes #23273

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(generate:releaseNotes): Include changesets with no packages in release notes #23273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build-tools/packages/build-cli/src/commands/generate/releaseNotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,14 @@ export default class GenerateReleaseNotesCommand extends BaseCommand<

body.append(`## ${sectionHead}\n\n`);
for (const change of changes) {
if (change.changeTypes.includes("minor") || flags.releaseType === "major") {
if (
// A changeset may apply to no packages, in which case the changeTypes.length will be 0. Such changesets are
// useful to add information to the release notes that don't apply to individual packages. Also useful when
// the relevant packages have all been deleted.
change.changeTypes.length === 0 ||
// If the change's type matches the release type flag, the change should be included.
change.changeTypes.includes(flags.releaseType)
) {
const pr = change.commit?.githubPullRequest;
const changeTitle = pr === undefined ? change.summary : `${change.summary} (#${pr})`;
body.append(`### ${changeTitle}\n\n${change.body}\n\n`);
Expand Down
Loading