refactor(build-tools): Deprecate some outdated commands and APIs #23280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
commented
Dec 10, 2024
| /** | ||
| * A CLI flag to parse the root directory of the Fluid repo. | ||
| */ | ||
| const rootPathFlag = Flags.custom({ |
tylerbutler
commented
Dec 10, 2024
zhenmichael
approved these changes
Dec 11, 2024
Josmithr
pushed a commit
to Josmithr/FluidFramework
that referenced
this pull request
Dec 12, 2024
…rosoft#23280) There are a number of build-tools APIs that should no longer be used for new code. We also have some commands that are no longer used and can be removed in the future. To help clarify which APIs and commands are definitely going away, I have made the following changes: 1. Removed the Timer class export from the build-tools package. 2. Removed use of Timer in the `check:layers` command, including the logtime flag. The flag was hidden and unused. 3. Updated Logger function signatures and implementations to be compatible with oclif logging functions, so that the base class can correctly call the logger used by the concrete instance. 4. Deprecated MonoRepoKind type and removed some uses in test files (prod code remains unchanged). 5. Deprecated FluidRepo, GitRepo, MonoRepo, readPackageJsonAndIndent, updatePackageJsonFile, updatePackageJsonFileAsync. 6. Updated build-cli lint config to only warn on uses of deprecated APIs _except_ for vnext code. [AB#19713](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/19713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of build-tools APIs that should no longer be used for new code. We also have some commands that are no longer used and can be removed in the future. To help clarify which APIs and commands are definitely going away, I have made the following changes:
check:layerscommand, including the logtime flag. The flag was hidden and unused.AB#19713
Next steps after merge:
Move logger interfaces and types to build-infra and use in both build-tools and build-cli.