Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy tags to the added apis for creating and loading container #23301

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Dec 11, 2024

Description

Add legacy tags to the added apis for creating and loading container. Earlier these apis only had the alpha tag which is not correct as Loop would not consume the alpha apis in prod code and also these depends on legacy things as well. So these apis could not just be alpha.

@Copilot Copilot bot review requested due to automatic review settings December 11, 2024 21:30
@jatgarg jatgarg requested a review from a team as a code owner December 11, 2024 21:30
@github-actions github-actions bot added base: main PRs targeted against main branch area: loader Loader related issues public api change Changes to a public API labels Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


@jatgarg jatgarg merged commit f8b8e01 into microsoft:main Dec 12, 2024
34 checks passed
Josmithr pushed a commit to Josmithr/FluidFramework that referenced this pull request Dec 12, 2024
…icrosoft#23301)

## Description

Add legacy tags to the added apis for creating and loading container.
Earlier these apis only had the alpha tag which is not correct as Loop
would not consume the alpha apis in prod code and also these depends on
legacy things as well. So these apis could not just be alpha.

Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
@jatgarg jatgarg deleted the loader1 branch December 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants