Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): Run biome #23310

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(style): Run biome #23310

merged 1 commit into from
Dec 12, 2024

Conversation

Josmithr
Copy link
Contributor

Somehow, a formatting issue escaped our PR validation in #23304. This PR runs Biome to format that file.

@Josmithr
Copy link
Contributor Author

@tylerbutler The linked PR made a change that violated formatting expectations, but the PR pipelines did not catch it. Subsequent PRs have been failing the client pipeline. It seems to me that:

  1. Specific release group pipelines shouldn't be validating the formatting of files that live at the root of the repo. Unless the client release group is treated specially here, since it lives at the root.
  2. The relevant pipeline(s) that check formatting of files at the repo root are not being triggered to re-run on changes to those files.

Seems like we need to fix at least 1 of the above somewhat urgently to prevent future issues like these. Curious which direction you think would be more appropriate in the short term.

@Josmithr Josmithr enabled auto-merge (squash) December 12, 2024 00:33
@Josmithr Josmithr merged commit accb839 into microsoft:main Dec 12, 2024
23 checks passed
@Josmithr Josmithr deleted the fix-style-issue branch December 12, 2024 00:43
Josmithr added a commit to Josmithr/FluidFramework that referenced this pull request Dec 12, 2024
Somehow, a formatting issue escaped our PR validation in microsoft#23304. This PR
runs Biome to format that file.
Josmithr added a commit to Josmithr/FluidFramework that referenced this pull request Dec 12, 2024
Somehow, a formatting issue escaped our PR validation in microsoft#23304. This PR
runs Biome to format that file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: contributor experience base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants