Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Remove trailing slash fix for now #23316

Merged

Conversation

Josmithr
Copy link
Contributor

Reverts a change made in #23304, which ultimately results in the unwanted redirects resulting from the following SWA bug: Azure/static-web-apps#1036.

@Josmithr Josmithr requested review from alexvy86, WayneFerrao and a team December 12, 2024 18:57
@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Dec 12, 2024
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr merged commit aa49281 into microsoft:main Dec 12, 2024
29 checks passed
@Josmithr Josmithr deleted the docs/remove-trailing-slash-setting branch December 12, 2024 19:58
Josmithr added a commit to Josmithr/FluidFramework that referenced this pull request Dec 12, 2024
Reverts a change made in microsoft#23304, which ultimately results in the
unwanted redirects resulting from the following SWA bug:
<Azure/static-web-apps#1036>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants