-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(Container): Add IContainer.closedWithError to access the error that closed or disposed the container" #23399
Conversation
… error t…" This reverts commit 711d05a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/test/test-end-to-end-tests/src/test/container.spec.ts:694
- Verify that the change in the error message from
"dispose error"
to"expected"
is correct and does not introduce any unintended side effects.
container.dispose(new DataCorruptionError("expected", {}));
packages/test/test-end-to-end-tests/src/test/container.spec.ts:747
- Verify that the change in the error message from
"close error"
to"expected"
is correct and does not introduce any unintended side effects.
container.close(new DataCorruptionError("expected", {}));
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.loader.container-loader.src:
Line Coverage Change: -0.01% Branch Coverage Change: -0.02%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 91.33% | 91.31% | ↓ -0.02% |
Line Coverage | 94.71% | 94.70% | ↓ -0.01% |
Baseline commit: 58619c3
Baseline build: 313974
Happy Coding!!
Code coverage comparison check passed!!
⯆ @fluid-example/bundle-size-tests: -460 Bytes
Baseline commit: 58619c3 |
Description
Reverts #23364
This change appears to cause errors in our end to end stress tests.