Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark deps and fix lints #23425

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

CraigMacomber
Copy link
Contributor

Description

Update dependencies for benchmark package, and fix new lint errors from update.

Reviewer Guidance

The review process is outlined on this wiki page.

@Copilot Copilot bot review requested due to automatic review settings January 2, 2025 21:20
@github-actions github-actions bot added base: main PRs targeted against main branch public api change Changes to a public API labels Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • tools/benchmark/package.json: Language not supported
  • tools/benchmark/src/resultFormatting.ts: Evaluated as low risk
  • tools/benchmark/src/mocha/memoryTestRunner.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

tools/benchmark/src/Reporter.ts:296

  • Corrected the spelling of 'suggets' to 'suggests'.
// As the name suggests, `customData` should only contain custom data that are specific to the benchmark test.
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@CraigMacomber CraigMacomber merged commit 21ab4c7 into microsoft:main Jan 2, 2025
31 checks passed
@CraigMacomber CraigMacomber deleted the benchUp branch January 2, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants