Try to identify customer issued close vs timeout #23442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangxin511
requested review from
pradeepvairamani,
znewton,
shubhi1092 and
Copilot
github-actions
bot
added
area: server
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts:74
- The word 'enssentially' should be corrected to 'essentially'.
// We observed 499 errors are sometime due to client side closed quickly before server can respond. Sometimes are due to
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts:80
- Ensure that the new behavior for differentiating client disconnections and server timeouts is covered by tests.
request.socket.on("close", () => {
| response.locals.clientDisconnected = false; | ||
| response.locals.serverTimeout = false; | ||
| // We observed 499 errors are sometime due to client side closed quickly before server can respond. Sometimes are due to | ||
| // server side timeout which got terminated by the idle timeout we set in createAndConfigureHttpServer call. |
There was a problem hiding this comment.
The word 'timoout' should be corrected to 'timeout'.
Suggested change
| // server side timeout which got terminated by the idle timeout we set in createAndConfigureHttpServer call. | |
| 75 + // server side timeout which got terminated by the idle timeout we set in createAndConfigureHttpServer call. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
pradeepvairamani
approved these changes
Jan 3, 2025
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Show resolved
Hide resolved
zhangxin511
deleted the
zhangxin/Distinguish499ByServerTimeoutOrClientInitilized
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For durable containers, 90% errors are status_unavialbe, which essentially 499, that connect closed before response sent. 90% of such errors, are actually pretty short, less than 2 seconds. These errors were due to client closed the connection too fast and we can replicate this easily. However, on our logging middleware, these all recorded with status code
status_unknow. This change will try to identify these connection break is due to client closed or due to the idle timeout we setBreaking Changes
N/A