test: skip flaky stashed ops test #23462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
yann-achard-MS
requested review from
Copilot and
markfields
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
markfields
reviewed
Jan 6, 2025
| @@ -2204,7 +2204,7 @@ describeCompat( | |||
| }, | |||
| ); | |||
|
|
|||
| itExpects( | |||
| itExpects.skip( | |||
There was a problem hiding this comment.
Please let it run for localServer, but you can skip for other drivers while I investigate. This is a new failure compared to the one I fixed last time.
markfields
reviewed
Jan 6, 2025
| @@ -2204,7 +2207,7 @@ describeCompat( | |||
| }, | |||
| ); | |||
|
|
|||
| itExpects( | |||
| (provider?.driver.type === "local" ? itExpects : itExpects.skip)( | |||
There was a problem hiding this comment.
More common way is to do if (provider.driver.type !== "local") { this.skip(); } inside the test fn. This looks fine too, I'll have it fixed up soon. JFYI if you make more changes like this.
There was a problem hiding this comment.
OMG, I never knew about this.skip()! This is so much better! Changing it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip "Parallel Forks: Closes (ForkedContainerError and DuplicateBatchError) when hydrating twice and submitting in parallel (via Counter DDS)" since it has been causing multiple build failures.
See https://dev.azure.com/fluidframework/internal/_workitems/edit/27482
Breaking Changes
None