Added response size contraints in Gitrest #23474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SizeMiddleware.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…to vermadhr/responseSizeMiddleware
github-actions
bot
added
area: server
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- server/gitrest/packages/gitrest-base/package.json: Language not supported
- server/historian/packages/historian-base/package.json: Language not supported
znewton
approved these changes
Jan 6, 2025
pradeepvairamani
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a response size constraint in Gitrest. This would mean that if an API call to Gitrest ends up returning a response body that is greater than the
responseSizeLimitInMegabytes, then the client will receive a 413. This is added to prevent large summaries being returned to Historian. Previously these large summaries have caused Historian OOM errors.