Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Flakiness: MigrationShim can drop v1 ops and migration ops #23478

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Jan 7, 2025

AB#18574

Based on telemetry indicating that this provider.ensureSynchronized call is hanging as the error message indicates so and as there are disconnects called during the test that would send telemetry but aren't, we can assume that the one that is hanging should be removed to reduce flakiness.

@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 01:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Jan 7, 2025
@tyler-cai-microsoft tyler-cai-microsoft changed the title Remove provider.ensureSynchronized that was timing out Fix Test Flakiness: MigrationShim can drop v1 ops and migration ops Jan 7, 2025
@tyler-cai-microsoft tyler-cai-microsoft merged commit 89dec15 into microsoft:main Jan 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants