Partially revert #23432 "Prefix ... no-unchecked-record-access..." #23486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cord-access for client packages (microsoft#23432)" This reverts commit 88caebd where `?` was used to address linter defect. Many of the test uses of `?` in original change are permissible as there is a follow-up assertion that will fail. But those were not separated during revert. Changes from original commit that used expected safe adjustments are retained.
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (13)
- packages/dds/map/src/test/mocha/directory.spec.ts: Evaluated as low risk
- packages/runtime/id-compressor/src/test/idCompressor.spec.ts: Evaluated as low risk
- packages/runtime/runtime-utils/src/test/summaryUtils.spec.ts: Evaluated as low risk
- packages/test/test-drivers/src/odspTestDriver.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/test/gc/gcStats.spec.ts: Evaluated as low risk
- packages/drivers/odsp-driver/src/test/prefetchSnapshotTests.spec.ts: Evaluated as low risk
- packages/drivers/routerlicious-driver/src/documentServiceFactory.ts: Evaluated as low risk
- packages/dds/map/src/directory.ts: Evaluated as low risk
- experimental/dds/attributable-map/src/mapKernel.ts: Evaluated as low risk
- packages/drivers/odsp-driver/src/odspDriverUrlResolver.ts: Evaluated as low risk
- packages/drivers/routerlicious-driver/src/documentService.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/test/containerRuntime.spec.ts: Evaluated as low risk
- packages/dds/map/src/mapKernel.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
packages/loader/driver-utils/src/test/summaryCompresssionTester.spec.ts:72
- Direct property access without optional chaining may cause runtime errors if 'tree' is undefined. Ensure 'tree' is always defined or add appropriate checks.
).tree.header;
packages/loader/driver-utils/src/test/summaryCompresssionTester.spec.ts:94
- Direct property access without optional chaining may cause runtime errors if 'tree' is undefined. Ensure 'tree' is always defined or add appropriate checks.
).tree.header;
packages/loader/driver-utils/src/test/summaryCompresssionTester.spec.ts:624
- Direct property access without optional chaining may cause runtime errors if 'tree' is undefined. Ensure 'tree' is always defined or add appropriate checks.
return getHeaderHolder(summary).tree.header;
…rd-access for client packages (microsoft#23432)" This reverts commit 88caebd where `T | undefined` was used to address linter defect. TypeScript will narrow without `undefined` without noUncheckedIndexAccess enabled. So remove ineffective pattern. The only files that retained changes are: packages/dds/merge-tree/src/test/beastTest.spec.ts packages/drivers/odsp-driver/src/WriteBufferUtils.ts packages/runtime/id-compressor/src/test/idCompressor.spec.ts packages/tools/fetch-tool/src/fluidFetchSnapshot.ts
anthony-murphy
approved these changes
Jan 7, 2025
Abe27342
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert "Prefix trivial issues when enabling no-unchecked-record-access for client packages (#23432)"
This reverts commit 88caebd where:
?was used to address linter defect. TypeScript appears to mostly ignore that these cases may lead toundefinedresult which is not accepted per type specifications. Use of?is thus a behavior change that will shift point of failure away from where it could first be detected - revert those behavior changes. (Many of the test uses of?in original change are permissible as there is a follow-up assertion that will fail. But those were not separated during revert.)T | undefinedwas used to address linter defect. TypeScript will narrow withoutundefinedwithoutnoUncheckedIndexAccessenabled.The only files that retained changes from original commit are:
packages/dds/merge-tree/src/test/beastTest.spec.ts
packages/drivers/odsp-driver/src/WriteBufferUtils.ts
packages/runtime/id-compressor/src/test/idCompressor.spec.ts
packages/tools/fetch-tool/src/fluidFetchSnapshot.ts