Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(telemetry-utils): Merge MockLogger2 into MockLogger #23526

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

alexvy86
Copy link
Contributor

Description

Merges the MockLogger2 and MockLogger classes now that MockLogger has been made @internal. Just one method needed to be moved over since MockLogger2 already extended MockLogger.

Reviewer Guidance

The review process is outlined on this wiki page.

@Copilot Copilot bot review requested due to automatic review settings January 11, 2025 16:56
@github-actions github-actions bot added the area: runtime Runtime related issues label Jan 11, 2025
@alexvy86 alexvy86 requested review from markfields and removed request for Copilot January 11, 2025 16:57
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jan 11, 2025
@alexvy86 alexvy86 requested a review from a team January 11, 2025 16:57
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexvy86 alexvy86 merged commit d58210c into microsoft:main Jan 13, 2025
26 checks passed
@alexvy86 alexvy86 deleted the merge-mocklogger2 branch January 13, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants