Make ts-common-config.json extends tsconfig.base.json

[CraigMacomber]

Description

Make deprecated common/build/build-common/ts-common-config.json extend common/build/build-common/tsconfig.base.json.

This avoids duplicating things like selecting the target.

As noted in common/build/build-common/README.md, tsconfig.base.json is the "base config contains defaults that all packages within the repo should use as a baseline".
This change causes the packages which use ts-common-config.json to follow this pattern, allowing tsconfig.base.json to better fill its role as the actual base configuration which provides a single source of truth for some of our build options.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• common/build/build-common/ts-common-config.json: Language not supported

[jason-ha]

I am assuming the intent here is to highlight how this differs from base and make it so that changes to base reach more even if they are out of date on config updates. I'd note that in the description.
Additional clean up that looks like it could be done immediately is to delete tsconfig.test.json, tsconfig.esm.json, and tsconfig.esm-only.json.

[jason-ha]

I would strike this comment. I am confident that the "common" in the name means it is shared. But that isn't useful really since it is deprecated.

[CraigMacomber]

As is this comment conveys more useful information (implying why the other configs don't follow this pattern of calling themselves common which might be confusing if we simply point out common means shared here, as that applies to every config in this package)

[jason-ha]

What I read, when I read the comment, is that the author doesn't really know the meaning, but happily this file currently satisfies two things.
The aspect that seems unfortunate is that we don't want this to be common/shared. Just feels a bit like it degrades the don't use this message from the line above. But I'm okay with keeping it.

[CraigMacomber]

I am assuming the intent here is to highlight how this differs from base and make it so that changes to base reach more even if they are out of date on config updates. I'd note that in the description.

Yes. Done.

Additional clean up that looks like it could be done immediately is to delete tsconfig.test.json, tsconfig.esm.json, and tsconfig.esm-only.json.

That seems likely. Might be good to update packages/framework/client-logger/fluid-telemetry/tsconfig.json and remove tsconfig.cjs.json at the same time (that or update the docs to move it out of "Legacy tsconfig"). Do you want to make that change?

[tylerbutler]

Note that this change alone will not affect some packages, including those in /common and /server, because those packages extend from the version in their build-common dependency, @fluidframework/build-common/ts-common-config.json. I think that's probably preferred but it will require more changes to switch the other packages to use relative paths instead of the dependency version.

[jason-ha]

That seems likely. Might be good to update packages/framework/client-logger/fluid-telemetry/tsconfig.json and remove tsconfig.cjs.json at the same time (that or update the docs to move it out of "Legacy tsconfig"). Do you want to make that change?

#23534