Vermadhr/keyless access work #23554
Merged
Vermadhr/keyless access work #23554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to vermadhr/keylessAccessWork
…to vermadhr/keylessAccessWork
…Access a mandatory prop
dhr-verma
requested review from
Copilot,
znewton and
pradeepvairamani
and removed request for
Copilot
github-actions
bot
added
area: server
pradeepvairamani
approved these changes
Jan 15, 2025
Merged
dhr-verma
added a commit
that referenced
this pull request
Jan 15, 2025
## Description Bumped r11 pacakges to consume changes from #23554 --------- Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a fix for a bug introduced in #23407. #23407 removed internal
getKeyAPI calls. However, the alternative to sign tokens by Riddler was not working for cases where we spoof user tokens (Scribe -> Alfred, Scribe -> Historian). This is because the token after expiry was never refreshed.This PR fixes this by adding a new callback to the
BasicRestWrapper-refreshTokenIfNeeded. This callback can handle refreshing auth tokens if provided.Breaking Changes
This change should not have breaking changes.
Reviewer Guidance