Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test-loader-utils): Updated eslint to use recommended config #23593

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

WayneFerrao
Copy link
Contributor

##Description

This PR updates the eslint config for test-loader-utils to use the recommended config.

@WayneFerrao WayneFerrao requested review from a team and Copilot January 16, 2025 23:25
@github-actions github-actions bot added area: loader Loader related issues base: main PRs targeted against main branch labels Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/loader/test-loader-utils/src/mockDocumentDeltaConnection.ts:61

  • Ensure that submitSignalHandler can handle unknown types correctly.
private readonly submitSignalHandler?: (message: unknown) => void,

packages/loader/test-loader-utils/src/mockDocumentDeltaConnection.ts:72

  • Ensure that submitSignalHandler can handle unknown types correctly.
public submitSignal(message: unknown): void {
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thank you!!

@WayneFerrao WayneFerrao merged commit c16bc56 into microsoft:main Jan 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants