build(client-azure-client): cleanup dependencies #23650
Conversation
- Removed [unused] production dependencies: `map` and `runtime-utils` - Import `SharedMap` and `SharedTree` from `fluid-framework`. - `SharedTree` is different between `tree` and `fluid-framework` exports. The test code that is using `SharedTree` wants to use the `fluid-framework` `@public` version but was using the `@legacy` version from `tree`. (Really `tree` should expose both, but it is understandable why it is the way it is.) - For best patterns and consistency, `SharedMap` should be pulled from `fluid-framework` instead of `map`. - Then neither `map` nor `tree` are required dependencies and are removed. - Removed dev dependencies: aqueduct
jason-ha
requested review from
Copilot,
alexvy86,
ChumpChief,
Josmithr and
sonalideshpandemsft
and removed request for
Copilot
github-actions
bot
added
dependencies
| @@ -128,6 +124,7 @@ | |||
| "cross-env": "^7.0.3", | |||
| "eslint": "~8.55.0", | |||
| "eslint-config-prettier": "~9.0.0", | |||
| "fluid-framework": "workspace:~", | |||
There was a problem hiding this comment.
I think this is probably fine since it's a dev dependency and only for use in testing (to make it more authentic to what a customer would do)?
I do think we should continue to avoid taking non-dev dependencies on fluid-framework in our own packages to keep our layering simple.
There was a problem hiding this comment.
I do think we should continue to avoid taking non-dev dependencies on fluid-framework in our own packages to keep our layering simple.
I agree, but hereby present what seems like a legit exception to the rule 😄 : #23647. That's an e2e tests package though, which arguably should be a @fluid-internal one (I'd say @fluid-private but I suspect we do need it published internally due to how we run those tests)
There was a problem hiding this comment.
Oh agree, was mostly thinking about product (shipping) packages. Anywhere where we are acting "as a customer would" (e2e tests, examples, etc.) the dependency seems fine to me.
that appeared in microsoft#23650 but unrelated to the dependency changes
mapandruntime-utilsSharedMapandSharedTreefromfluid-framework.SharedTreeis different betweentreeandfluid-frameworkexports. The test code that is usingSharedTreewants to use thefluid-framework@publicversion but was using the@legacyversion fromtree. (Reallytreeshould expose both, but it is understandable why it is the way it is.)SharedMapshould be pulled fromfluid-frameworkinstead ofmap.mapnortreeare required dependencies and are removed.