Summary cleanup [0.10] #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2019 15:22
vladsud
approved these changes
Oct 3, 2019
arinwt
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Summary cleanup [0.10] (#244) * Add logger to SummaryManager; move ITreeEntry implementations to core-utils package * Cleanup SummaryManager * Fix tests * Export summaryTreeConverter * Rename properties on container sublogger * Do not try to submit summary op while disconnected [0.10] (#263) * Do not try to submit summary op while disconnected * Move comment to correct place * Add more checks for disconnected during generate summary * Prevent summarizer from pending timeout while still generating summary (#276) * Summarizer telemetry and cleanup (#327) * Add initialSequenceNumber to DeltaManager and use it for summarizer * Add message for summary reason * Add more wrapping performance events around both summarize and generateSummary * Add progress steps to generate summary perf event * Add timer for pending timeout and summarize timeout and prevent disconnect too early * Wait and fetch summaryConfiguration after we are connected * Fix unit tests * Small PR changes * Return early if disconnected before run and add telemetry event * Rename and do not wait for connected if stopped. * Only realize component if changed while summarizing (#328) * Only realize component if changed while summarizing * Elaborate on comments * Fix tslint
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes related to recent summary changes:
Fixes #108.