Null attach snapshots #3108
Merged
Null attach snapshots #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The snapshot tests were still not failing, so I created an issue to track: #3107 |
vladsud
reviewed
Aug 12, 2020
vladsud
reviewed
Aug 12, 2020
| @@ -697,6 +707,7 @@ export class LocalFluidDataStoreContext extends FluidDataStoreContext { | |||
| BindState.NotBound, | |||
| bindChannel, | |||
| pkg); | |||
| this.pkg = pkg; // TODO: avoid setting twice | |||
There was a problem hiding this comment.
curious, why is this required?
There was a problem hiding this comment.
It allows me to make the pkg property overload in LocalFluidDataStoreContext readonly defined (not undefined). There's probably a cleaner way to do it with a bigger refactor, but I just wanted something quick.
vladsud
approved these changes
Aug 13, 2020
This was referenced Aug 18, 2022
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
InboundAttachMessagetype to handle null snapshots.Use empty tree with only ".component" attributes blob when attach snapshot is missing.
Also fixes the snapshot tests so they can be ran from Debug Current Test vscode launch task. This is confined to the first commit.