Add bundle analysis collection and publish steps #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocliu
changed the title
markfields
approved these changes
Aug 14, 2020
|
|
||
| - task: PublishBuildArtifacts@1 | ||
| displayName: Publish Artifacts - bundle-analysis | ||
| condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest')) |
There was a problem hiding this comment.
succeeded() is set based on the previous task? That's cool.
| displayName: Publish Artifacts - bundle-analysis | ||
| condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest')) | ||
| inputs: | ||
| PathtoPublish: '${{ parameters.buildDirectory }}/artifacts/bundleAnalysis' |
There was a problem hiding this comment.
This is a different path than used for the Docs one below, is that intentional? How did you choose this path?
There was a problem hiding this comment.
It's the path to the stuff that gets published; this just happened to be where the bundle analysis stuff went. it may be better to group it all closer together? not sure it matters much though.
This was referenced Aug 18, 2022
This was referenced Aug 19, 2022
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2449
Add build steps to collect and publish bundle analysis to build artifacts