Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script with repo package manifest and release ordering #3658

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

sumedhb1995
Copy link
Contributor

@sumedhb1995 sumedhb1995 commented Sep 16, 2020

  • Update FluidRepoBase to not be specific to the FDL repo but instead be able to customized using parameters for different Fluid repos
  • Renamed FluidRepoBase -> FluidRepo and FluidRepo -> FluidRepoBuild to clarify use cases for the classes
  • Read package description from the new fluidBuild parameter in package.json
  • Add release order to package.json instead of having it hardcode in bumpVersion.ts

Based off of feedback from #3190

Copy link
Member

@curtisman curtisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sumedhb1995 sumedhb1995 merged commit 680dcc6 into microsoft:main Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fluid-build script to be compatible with different Fluid repos
2 participants