Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom file extensions in odsp driver #4044

Merged
merged 11 commits into from
Oct 28, 2020
Merged

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Oct 22, 2020

This will enable different apps to have different extensions for the ff files.

@jatgarg jatgarg added area: loader Loader related issues area: driver Driver related issues labels Oct 22, 2020
@jatgarg jatgarg added this to the October 2020 milestone Oct 22, 2020
@jatgarg jatgarg self-assigned this Oct 22, 2020
packages/drivers/odsp-driver/src/createFile.ts Outdated Show resolved Hide resolved
packages/drivers/odsp-driver/src/createFile.ts Outdated Show resolved Hide resolved
packages/loader/container-loader/src/container.ts Outdated Show resolved Hide resolved
packages/loader/container-loader/src/container.ts Outdated Show resolved Hide resolved
packages/drivers/odsp-driver/src/createFile.ts Outdated Show resolved Hide resolved
@jatgarg jatgarg closed this Oct 22, 2020
@jatgarg jatgarg reopened this Oct 22, 2020
@jatgarg jatgarg requested a review from leeviana October 22, 2020 17:20
@curtisman
Copy link
Member

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@curtisman
Copy link
Member

/azp run repo-policy-check

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@curtisman
Copy link
Member

Closing and reopening to trigger build

@curtisman curtisman closed this Oct 23, 2020
@curtisman curtisman reopened this Oct 23, 2020
@github-actions github-actions bot requested a review from vladsud October 23, 2020 17:28
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 27, 2020

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 176.53 KB 176.53 KB No change
Total Size 176.53 KB 176.53 KB No change
@fluid-example/bundle-size-tests: No change
Metric NameBaseline SizeCompare SizeSize Diff
container.js 246.99 KB 246.99 KB No change
sharedString.js 232.99 KB 232.99 KB No change
Total Size 479.98 KB 479.98 KB No change

Baseline commit: daa2802

Generated by 🚫 dangerJS against 83222be

@jatgarg jatgarg requested a review from leeviana October 27, 2020 19:05
@jatgarg jatgarg changed the title Enable custom file extensions according to different container package names Enable custom file extensions in odsp driver Oct 27, 2020
Copy link
Contributor

@vladsud vladsud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add note in breaking.md

@github-actions github-actions bot requested a review from vladsud October 28, 2020 22:27
@github-actions github-actions bot requested a review from tylerbutler October 28, 2020 22:35
@jatgarg jatgarg merged commit 3f1f557 into microsoft:main Oct 28, 2020
@jatgarg jatgarg deleted the fluidext branch October 28, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: loader Loader related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants