-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom file extensions in odsp driver #4044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatgarg
added
area: loader
Loader related issues
area: driver
Driver related issues
labels
Oct 22, 2020
jatgarg
requested review from
anthony-murphy,
abrahamrq,
leeviana and
vladsud
October 22, 2020 16:53
leeviana
reviewed
Oct 22, 2020
packages/drivers/odsp-driver/src/odspDocumentServiceFactoryCore.ts
Outdated
Show resolved
Hide resolved
/azp where |
Azure DevOps orgs getting events for this repository: |
/azp run repo-policy-check |
Azure Pipelines successfully started running 1 pipeline(s). |
leeviana
approved these changes
Oct 23, 2020
vladsud
reviewed
Oct 23, 2020
Closing and reopening to trigger build |
■ @fluidframework/base-host: No change
■ @fluid-example/bundle-size-tests: No change
Baseline commit: daa2802 |
jatgarg
commented
Oct 27, 2020
jatgarg
changed the title
Enable custom file extensions according to different container package names
Enable custom file extensions in odsp driver
Oct 27, 2020
vladsud
reviewed
Oct 28, 2020
vladsud
reviewed
Oct 28, 2020
vladsud
reviewed
Oct 28, 2020
vladsud
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add note in breaking.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable different apps to have different extensions for the ff files.