-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Skipping Context Reload when New Code is Compatible with Old #4122
Merged
anthony-murphy
merged 24 commits into
microsoft:main
from
anthony-murphy:compatible-code-details
Oct 29, 2020
Merged
Support Skipping Context Reload when New Code is Compatible with Old #4122
anthony-murphy
merged 24 commits into
microsoft:main
from
anthony-murphy:compatible-code-details
Oct 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
…to compatible-code-details
⯅ @fluidframework/base-host: +721 Bytes
⯅ @fluid-example/bundle-size-tests: +97 Bytes
Baseline commit: 3cac20d |
…to compatible-code-details
arinwt
reviewed
Oct 28, 2020
…to compatible-code-details
…to compatible-code-details
arinwt
reviewed
Oct 29, 2020
This was referenced Aug 19, 2022
Open
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 20, 2022
Open
Open
This was referenced Aug 20, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds IFluidCodeDetailsComparer interface that supports comparison, and constraint satisfaction. The interface has two methods: compare and satisfies. Compare can be used to determine if code should be proposed, as it provides relative ordering for the code details. Satisfies determine if a code details satisfies the constraints of another code details. This is used to determine if we can continue using the existing runtime without reload when a new code proposal comes in.
The IFluidCodeDetailsComparer is supported on both the code loader, and the fluid export. The code loader is the host provided entry point and the fluid export is the container authors entry point. The interface is optional on both.
Expose the current code details off IRuntime. This will allow the runtime to reject incompatible changes
Last but not least are a bunch of test updates, and a new test scenario to cover the usages of IFluidCodeDetailsComparer. Specifically, proposing a new code proposal that is satisfied by the existing code proposal, so no reload of the context is necessary.
related #3481
related #3529