-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local token provider for r11s driver #4126
Conversation
■ @fluidframework/base-host: No change
■ @fluid-example/bundle-size-tests: No change
Baseline commit: 85293a9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
* As the name implies this is not secure and should not be used in production. It simply makes the example easier | ||
* to get up and running. | ||
*/ | ||
export class InsecureTokenProvider implements ITokenProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we reuse the other token provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
I don't quite like the fact that test-runtime-utils is taking a dependency to routerlicious-driver package. Feels like it belongs to some routerlicious specific thing. |
Totally agree. I thought about it but did not find a better place. r11s-driver bundles the interfaces and implementations in one single package. And driver-base seems to be shared between both drivers. Any recommendation on placing the ITokenProvider interface? |
Follow up of #3954. This PR adds a local token provider for r11s drivers to use. Following the model of InsecureUrlResolver, this one is called InsecureTokenProvider. The provider is meant to be used for testing and local running purposes.
InsecureUrlResolver still signs a jwt token. Next PR will remove the signing part from and drivers will only rely on token provider.