Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last reference to SummaryTracker #4707

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

arinwt
Copy link
Contributor

@arinwt arinwt commented Jan 4, 2021

Fixes #3243

Also included another back-compat removal change needed in 0.34. It is a context reload compat test change needed as a result of hot-swap context removal by default. PR for back-compat change: #4765.

@github-actions github-actions bot requested review from vladsud and curtisman January 4, 2021 18:30
@arinwt
Copy link
Contributor Author

arinwt commented Jan 5, 2021

Going to hold this PR until 0.33 is released so that it goes into 0.34 instead.
Currently compatibility requirement is +/- 2 versions, and the original removal happened in 0.31.

@anthony-murphy
Copy link
Contributor

@arinwt can this go in now?

@msfluid-bot
Copy link
Collaborator

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 168.34 KB 168.34 KB No change
Total Size 168.34 KB 168.34 KB No change
@fluid-example/bundle-size-tests: -83 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 193.11 KB 193.02 KB -83 Bytes
map.js 45.77 KB 45.77 KB No change
matrix.js 143.98 KB 143.98 KB No change
odspDriver.js 195.24 KB 195.24 KB No change
sharedString.js 158.09 KB 158.09 KB No change
Total Size 736.19 KB 736.11 KB -83 Bytes

Baseline commit: 11f2583

Generated by 🚫 dangerJS against dea22a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove back-compat code for SummaryTracker
4 participants