Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial change to fix some warning if strictNullCheck is enabled for merge-tree package #4812

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

curtisman
Copy link
Member

@curtisman curtisman commented Jan 13, 2021

strictNullCheck for merge-tree is not enabled by default yet. Doing it in multiple PR to manage churn and change size.

Mostly simple change to typing to add undefined

Related to #2358

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jan 13, 2021

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 166.8 KB 166.8 KB No change
Total Size 166.8 KB 166.8 KB No change
@fluid-example/bundle-size-tests: -124 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 192.26 KB 192.26 KB No change
map.js 45.9 KB 45.9 KB No change
matrix.js 144.54 KB 144.48 KB -62 Bytes
odspDriver.js 192.74 KB 192.74 KB No change
sharedString.js 158.59 KB 158.53 KB -62 Bytes
Total Size 734.02 KB 733.9 KB -124 Bytes

Baseline commit: 0ec7ac7

Generated by 🚫 dangerJS against 4f46933

Co-authored-by: Tony Murphy <anthony.murphy@microsoft.com>
@curtisman curtisman merged commit 1a58fe5 into microsoft:main Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants