-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More partial fixes for enabling strictNullCheck. #4842
Conversation
■ @fluidframework/base-host: No change
⯆ @fluid-example/bundle-size-tests: -12 Bytes
Baseline commit: 693c752 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
continueSubtree(node: IntervalNode<T> | undefined, key: T) { | ||
const cont = node && node.data.minmax.overlaps(key); | ||
const cont = !!node && node.data.minmax.overlaps(key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double-bang was new syntax for me. :) https://medium.com/better-programming/javascript-bang-bang-i-shot-you-down-use-of-double-bangs-in-javascript-7c9d94446054
Related to #2358 |
No description provided.