Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More partial fixes for enabling strictNullCheck. #4842

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

curtisman
Copy link
Member

No description provided.

@msfluid-bot
Copy link
Collaborator

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 167.09 KB 167.09 KB No change
Total Size 167.09 KB 167.09 KB No change
@fluid-example/bundle-size-tests: -12 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 192.26 KB 192.26 KB No change
map.js 45.9 KB 45.9 KB No change
matrix.js 144.12 KB 144.11 KB -6 Bytes
odspDriver.js 192.74 KB 192.74 KB No change
sharedString.js 158.17 KB 158.17 KB -6 Bytes
Total Size 733.18 KB 733.17 KB -12 Bytes

Baseline commit: 693c752

Generated by 🚫 dangerJS against fe09774

Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

}

continueSubtree(node: IntervalNode<T> | undefined, key: T) {
const cont = node && node.data.minmax.overlaps(key);
const cont = !!node && node.data.minmax.overlaps(key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curtisman curtisman merged commit 3a05fab into microsoft:main Jan 19, 2021
@curtisman curtisman deleted the nullcheck branch February 3, 2021 01:20
@curtisman
Copy link
Member Author

Related to #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants