Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional epoch to IConnect message #4926

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add optional epoch to IConnect message #4926

merged 2 commits into from
Jan 27, 2021

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Jan 27, 2021 •
edited
Loading

Related to issue: #4899

Add epoch in IConnect message, so that is the client has it and wants to match on server, then it can pass it.

@jatgarg jatgarg self-assigned this Jan 27, 2021
@jatgarg jatgarg added the area: server Server related issues (routerlicious) label Jan 27, 2021
@jatgarg jatgarg added this to the January 2021 milestone Jan 27, 2021
@jatgarg jatgarg requested a review from GaryWilber January 27, 2021 00:12
@jatgarg jatgarg requested a review from vladsud January 27, 2021 00:12
tanviraumi
tanviraumi reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@tanviraumi tanviraumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this "fileEpoch/storageEpoch/summaryEpoch"? To make them more explicit?

@jatgarg
Copy link
Contributor Author

jatgarg commented Jan 27, 2021

Should we call this "fileEpoch/storageEpoch/summaryEpoch"? To make them more explicit?

@GaryWilber I think odsp already checks epoch field? Will it require a change on odsp server?

@github-actions github-actions bot requested a review from tanviraumi January 27, 2021 00:38
@jatgarg jatgarg merged commit cf78e37 into microsoft:main Jan 27, 2021
@GaryWilber
Copy link
Contributor

Should we call this "fileEpoch/storageEpoch/summaryEpoch"? To make them more explicit?

@GaryWilber I think odsp already checks epoch field? Will it require a change on odsp server?

We currently check epoch. Changing it would require server changes.

@jatgarg jatgarg deleted the serverconnect branch January 27, 2021 04:18
@snyk-bot snyk-bot mentioned this pull request Oct 17, 2022
Open
This was referenced Oct 17, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 17, 2022
Open
This was referenced Oct 17, 2022
Open
Open
Open
Open
This was referenced Oct 17, 2022
Open
Open
Open
This was referenced Oct 17, 2022
Open
Open
This was referenced Oct 18, 2022
Open
Open
Open
Open
Open
This was referenced Oct 18, 2022
Open
Open
Open
This was referenced Oct 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 20, 2022
Open
Open
Open
Open
This was referenced Oct 20, 2022
Open
Open
This was referenced Oct 31, 2022
Open
Open
This was referenced Oct 31, 2022
Open
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladsud vladsud vladsud approved these changes

@GaryWilber GaryWilber Awaiting requested review from GaryWilber

@anthony-murphy anthony-murphy Awaiting requested review from anthony-murphy

@tanviraumi tanviraumi Awaiting requested review from tanviraumi

Assignees

@jatgarg jatgarg

Labels
area: server Server related issues (routerlicious)
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@jatgarg @GaryWilber @tanviraumi @vladsud