Remove prelease dependencies on release packages #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arinwt
commented
Apr 15, 2021
arinwt
commented
arinwt
requested review from
agarwal-navin and
markfields
and removed request for
anthony-murphy and
tanviraumi
github-actions
bot
requested review from
vladsud,
curtisman,
skylerjokiel,
ChumpChief and
DLehenbauer
@fluidframework/common-utils -> ^0.29.0
Server -> ^0.1022.0
arinwt
force-pushed
the
dep_1618447958252
branch
from
d084bfd to
6bcd477
Compare
⯆ @fluidframework/base-host: -648 Bytes
⯆ @fluid-example/bundle-size-tests: -330 Bytes
Baseline commit: d8624a5 |
server/tinylicious/package.json
Outdated
| "@fluidframework/protocol-base": "^0.1017.1", | ||
| "@fluidframework/protocol-definitions": "^0.1017.1", | ||
| "@fluidframework/common-utils": "^0.29.0", | ||
| "@fluidframework/gitresources": "^0.1022.0", |
There was a problem hiding this comment.
it doesn't look like tinylicious has been updated for a while, any reason we need to do it this round? i see the build is failing, and looks like server breaking changes
There was a problem hiding this comment.
i would just revert the tinylicious change, and file a bug
There was a problem hiding this comment.
I'm not sure, this was just the result of running the bump command
There was a problem hiding this comment.
Okay I'm going to try manually reverting the package.json changes in tinylicious, then npm i
anthony-murphy
approved these changes
Apr 15, 2021
DLehenbauer
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.