Port https://github.com/microsoft/FluidFramework/pull/5773 to 0.38 #5850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses microsoft#5477 It gives a lot of flexibility to developers to control loading process. In particular, it allows Bohemia to apply cached ops before container is returned, and (optionally) allow ops from storage to continue to trickle in through initial boot / render cycle to speed up catch up process (this would need to be tested to ensure existing code behaves correctly in presence of changes).
github-actions
bot
requested review from
anthony-murphy,
arinwt,
curtisman,
markfields,
agarwal-navin,
tanviraumi,
GaryWilber and
hedasilv
⯅ @fluidframework/base-host: +1.09 KB
⯅ @fluid-example/bundle-size-tests: +6 Bytes
Baseline commit: 009f6ed |
|
I don't think it's integrated yet. I don't see any rush on this. I can do a patch release later tonight if needed. |
|
Thanks! Yes, it's a port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change did not make it into 0.38 by one day.
After discussing it with Jade, we are running out of time to get it into hosts (including Teams) before GA on 5/7, so porting looks like responsible step, given that release likely did not make it yet to Bohemia.
Please let me know if you feel it's too risky given where we are.
Addresses #5477
It gives a lot of flexibility to developers to control loading process.
In particular, it allows Bohemia to apply cached ops before container is returned, and (optionally) allow ops from storage to continue to trickle in through initial boot / render cycle to speed up catch up process (this would need to be tested to ensure existing code behaves correctly in presence of changes).