Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate summarizer client election logic #6592

Merged
merged 5 commits into from
Jun 30, 2021

Conversation

arinwt
Copy link
Contributor

@arinwt arinwt commented Jun 30, 2021

As requested by #6335 to split into separate PRs.

This change isolates the existing elected summarizer logic into its own class outside of SummaryManager. The new class is SummarizerClientElection, which depends on an OrderedClientElection.

The goal is to reduce code in SummaryManager and add tests for the summarizer client election logic.

@arinwt arinwt requested a review from anthony-murphy June 30, 2021 13:14
@github-actions github-actions bot requested review from vladsud and curtisman June 30, 2021 13:15
@github-actions github-actions bot added the area: runtime Runtime related issues label Jun 30, 2021
@arinwt arinwt added the refactor Code refactoring and cleanup label Jun 30, 2021
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jun 30, 2021

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 179.12 KB 179.12 KB No change
Total Size 179.12 KB 179.12 KB No change
@fluid-example/bundle-size-tests: +459 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 208.14 KB 208.59 KB +459 Bytes
map.js 48.39 KB 48.39 KB No change
matrix.js 146.8 KB 146.8 KB No change
odspDriver.js 196.86 KB 196.86 KB No change
odspPrefetchSnapshot.js 27.7 KB 27.7 KB No change
sharedString.js 163.19 KB 163.19 KB No change
Total Size 791.07 KB 791.52 KB +459 Bytes

Baseline commit: 6e977e8

Generated by 🚫 dangerJS against 363b96c

@arinwt arinwt requested a review from anthony-murphy June 30, 2021 20:09
@arinwt arinwt merged commit 1a6c1fc into microsoft:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants