Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apmahade/testretrymongo #7211

Merged
merged 225 commits into from
Aug 20, 2021
Merged

Conversation

appym31
Copy link
Contributor

@appym31 appym31 commented Aug 20, 2021

Merging in order to generate test packages

jatgarg and others added 30 commits July 22, 2021 14:52
* Add ability to disable summarizer heuristics

* Split summarize heuristic data from runner
Reduce calls on IContainerContext, reduce duplication of connection state management.
…microsoft#6858)

@fluidframework/build-common:     0.23.0 (unchanged)
     @fluidframework/eslint-config-fluid:     0.24.0 (unchanged)
      @fluidframework/common-definitions:     0.21.0 (unchanged)
            @fluidframework/common-utils:     0.32.0 (unchanged)
   @fluidframework/container-definitions:     0.40.0 (unchanged)
         @fluidframework/core-interfaces:     0.40.0 (unchanged)
      @fluidframework/driver-definitions:     0.40.0 (unchanged)
    @fluidframework/protocol-definitions:   0.1025.0 (unchanged)
                                  Server:   0.1028.0 (unchanged)
                                  Client:     0.44.0 -> 0.45.0
                  @fluid-tools/benchmark:     0.40.0 (unchanged)
                         generator-fluid:      0.3.0 (unchanged)
                             tinylicious:      0.4.0 (unchanged)
                             dice-roller:      0.0.1 (unchanged)
…7 everywhere (microsoft#6857)

* Bump dependencies version

   @fluidframework/container-definitions -> ^0.39.7

* Bump dependencies version

         @fluidframework/core-interfaces -> ^0.39.7

* update driver-definitions dep.

* lint

* revert driver-definitions bump

* revert changes in common/

* revert fix

* fix lerna and other package.jsons
- Remove advanced and concepts section. Everything is in /deep now.
- Add support for "outdated" and "discussion" article statuses.
- Add "placeholder" shortcode to mark unwritten sections in docs.
- Mark tutorial outdated.
P1 of fixing microsoft#6757

History here is we had a function to override the hashing function to enable scenarios where people wanted to do stuff locally involving insecure contexts (because crypto.subtle isn't available there). We decided against doing automatic fallback because it added the sha.js library to the webpack bundle for analyses and muddied those numbers (production impact is non-existent because it's a dynamic import).

Turns out irl usage quickly goes beyond "call this function here" and it's not at all clear what to do, so change this to automatic fallback. The time saved from not having to talk to people about this will far outweigh the risk of someone accidentally introducing a production dependency on the sha.js library and having to revert it.

(also cleanup some other build warning because it's annoying)
One of the problems with using IAudience is that only getting the clientId in the removeMember event can make it cumbersome to make incremental changes to data on audience members, because once the event fires the associated IClient is gone and you're stuck either keying your data on the clientId (where use cases tend to favor keying on a user) or iterating to match the clientId. Add the IClient to the args for the event to make this easier. Also handle the case where an audience join signal gets lost by only emitting an event when a member is actually removed, and log when we try to remove a non-existent member. There should be very little functional change for consumers by doing this because in these situations the consumer couldn't find the missing member in the audience anyway,
Allow changes to start and end independently of each other. A value of "undefined" passed as start or end indicates no change to that endpoint.
Part ??? of fixing microsoft#6757

Going through bumping all the layers to use prerelease versions of common-utils following a change there. This change bumps usages in serve/routerlicious.

Next steps:

Create prerelease for server 0.1028
Update client and tinylicious to use common-utils 0.32.0-0 and server 0.1028.0-0. Tinylicious must be updated here because the common-utils change is hashing changes to facilitate local testing in insecure environments, and that entire dependency chain needs to be updated.
Replace checkNotTimeout with raceTimer helper
As part of bumping the common-utils version. Client build is complaining there are multiple versions of base64-js, so bump the version in common-utils to latest to match the duplicate.
jatgarg and others added 8 commits August 19, 2021 11:29
Updates Tinylicious to use socket.io 4.1.2, same as Routerlicious.  Removes @types/socket.io (no longer required, the more recent versions of socket.io include typing).
…t docker image tag (microsoft#7181)

- PR microsoft#7159 subdivided the publish packages into scoped and non-scoped to be published in separate steps.  The server packages are all scoped and need to put into the right path for publishing
- NOTICE generation fail randomly, make it not required if we don't publish the docker image
- If we are doing manual test build, don't push it to the same container repository as the main official CI build (use `test/` instead of `build/`.
* Making sure node-rdkafka is compiled with SSL by adding SSL deps in out Dockerfile and avoiding volume mapping for it in docker-compose.dev.yaml. Also starting the experiment with some variables

* Adding support for SSL configs in RdKafka consuemer and producer classes

* Also enabling TLS for Kafka Admin Client

* Addomg Readme and updating config name

* Removing debug logs and updating Readme

* Throwing error if rdkafka tries to setup SSL but SSL is not enabled. Also adding more comments
@appym31 appym31 requested review from tylerbutler and a team as code owners August 20, 2021 22:39
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: host Host related issues area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc area: website breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Aug 20, 2021
@appym31 appym31 merged commit 550a1f2 into microsoft:test/apmahade2 Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: host Host related issues area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc area: website breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.