Fixed audience tests - It now waits for clients to be added to audience even after the client is connected #7280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce even after the client is connected
github-actions
bot
added
the
area: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7252
These tests were based on the assumption that if a client has moved to connected state, they will be in their audience. However, that is not the case today. Created an issue for this - #7275.
For now, the tests now have a wait of 2 seconds for clients to get into their audience after they are connected. The reason for choosing 2 seconds is explained in the issue. Once the issue is resolved, the tests should be updated to reflect the new behavior.