Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal usage of IFluidObject for IFluidModule, and IContainerContext.scope #7867

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

anthony-murphy
Copy link
Contributor

This change is in preparation for some changes coming to eventually remove IFluidObject as an uber interface, as the coupling of all types off a single interface leads to complex typing issues. This change just moves away from IFluidObject on some types that come from the definitions package, IFluidModule, and IContainerContext.scope. In a follow up i will be removing IFluidObject entirely from these types

related to #7613

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues labels Oct 15, 2021
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 15, 2021

@fluidframework/base-host: -15 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
main.js 189.09 KB 189.08 KB -15 Bytes
Total Size 216.68 KB 216.67 KB -15 Bytes
@fluid-example/bundle-size-tests: No change
Metric NameBaseline SizeCompare SizeSize Diff
container.js 163.54 KB 163.54 KB No change
map.js 44.71 KB 44.71 KB No change
matrix.js 143.36 KB 143.36 KB No change
odspDriver.js 182.13 KB 182.13 KB No change
odspPrefetchSnapshot.js 39.38 KB 39.38 KB No change
sharedString.js 164.93 KB 164.93 KB No change
Total Size 770.73 KB 770.73 KB No change

Baseline commit: 0d572f8

Generated by 🚫 dangerJS against ff8883b

@anthony-murphy anthony-murphy linked an issue Oct 18, 2021 that may be closed by this pull request
13 tasks
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂 LGTM, although I left a few comments for your consideration

@anthony-murphy anthony-murphy merged commit 67cfed7 into microsoft:main Oct 21, 2021
@anthony-murphy anthony-murphy deleted the dcouple-fluid-object branch October 21, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IFluidObject Alternative Without Module Augmentation
3 participants