-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal usage of IFluidObject for IFluidModule
, and IContainerContext.scope
#7867
Merged
anthony-murphy
merged 5 commits into
microsoft:main
from
anthony-murphy:dcouple-fluid-object
Oct 21, 2021
Merged
Remove internal usage of IFluidObject for IFluidModule
, and IContainerContext.scope
#7867
anthony-murphy
merged 5 commits into
microsoft:main
from
anthony-murphy:dcouple-fluid-object
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: loader
Loader related issues
labels
Oct 15, 2021
github-actions
bot
requested review from
skylerjokiel,
ChumpChief and
vladsud
October 15, 2021 15:52
⯆ @fluidframework/base-host: -15 Bytes
■ @fluid-example/bundle-size-tests: No change
Baseline commit: 0d572f8 |
13 tasks
markfields
reviewed
Oct 19, 2021
packages/framework/aqueduct/src/container-runtime-factories/baseContainerRuntimeFactory.ts
Show resolved
Hide resolved
markfields
reviewed
Oct 19, 2021
markfields
reviewed
Oct 19, 2021
markfields
reviewed
Oct 19, 2021
markfields
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎂 LGTM, although I left a few comments for your consideration
…to dcouple-fluid-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: loader
Loader related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in preparation for some changes coming to eventually remove IFluidObject as an uber interface, as the coupling of all types off a single interface leads to complex typing issues. This change just moves away from IFluidObject on some types that come from the definitions package,
IFluidModule
, andIContainerContext.scope
. In a follow up i will be removing IFluidObject entirely from these typesrelated to #7613