-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FluidObject utility type to Replace IFluidObject #8087
Merged
anthony-murphy
merged 19 commits into
microsoft:main
from
anthony-murphy:add-provider-types
Nov 15, 2021
Merged
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
783e40a
Add Provider Interface to Replace IFluidObject
anthony-murphy 21a29c8
update package lock
anthony-murphy 90d8b27
Apply suggestions from code review
anthony-murphy af0e1ad
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 16575a2
update package lock
anthony-murphy 0901c32
rename Provider to FluidObject
anthony-murphy ad3730e
update docs
anthony-murphy 4bcd210
remove unnecessary contraint
anthony-murphy cc3895b
deprecate fluid object properties
anthony-murphy 05aec76
revert test change
anthony-murphy 4b55caf
add back compat test
anthony-murphy 9ae4cd4
make readonly
anthony-murphy e86dd6e
exclude undfined
anthony-murphy 635ea00
Update common/lib/core-interfaces/src/provider.ts
anthony-murphy 9863417
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
anthony-murphy 6e5a492
Update common/lib/core-interfaces/src/provider.ts
anthony-murphy 41ed629
update a couple comments
anthony-murphy a5829ff
Merge branch 'add-provider-types' of https://github.com/anthony-murph…
anthony-murphy 6e8791b
Update common/lib/core-interfaces/src/provider.ts
anthony-murphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering renaming this to FluidObject, rather than Provider as i think it may make the transition easier for people.
Open to opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladsud and @markfields. what do you think here. i'm actually leaning towards the rename to IFluidObject, as i think it will be a less disruptive change for people.