Introduce IDeltaQueueWriter and a bit better tracking for connection issues #8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See microsoft#7312 for more details
…to TrackingInboundPauses
jatgarg
approved these changes
Nov 4, 2021
curtisman
reviewed
Nov 4, 2021
curtisman
reviewed
Nov 4, 2021
curtisman
reviewed
Nov 4, 2021
|
Note - for now I'm not going to merge this. I'm running it locally and occasionally can capture stacks, and they are pointing me in right direction. So it's possible I'll never merge it, though it might be useful for other things in the future. |
curtisman
reviewed
Nov 4, 2021
…to TrackingInboundPauses # Conflicts: # packages/loader/container-loader/src/deltaManager.ts
…to TrackingInboundPauses
|
Note - I'll be abandoning this direction, as manual stress testing points to offender, and through careful refactoring I got to the point where it's easy to see and fix this issue - the last leg of this journey is PR #8206 But I'll reuse this PR to introduce IDeltaQueueWriter which might be useful for future |
vladsud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7312 for more details