-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Core-Interface in client packages #8257
Bump Core-Interface in client packages #8257
Conversation
@@ -90,6 +90,8 @@ export const FileSnapshotWriterClassFactory: <TBase extends ReaderConstructor>(B | |||
createBlob(file: ArrayBufferLike): Promise<api.ICreateBlobResponse>; | |||
uploadSummaryWithContext(summary: api.ISummaryTree, context: ISummaryContext): Promise<string>; | |||
downloadSummary(handle: api.ISummaryHandle): Promise<api.ISummaryTree>; | |||
readonly disposed?: boolean | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else { | ||
connection.close(); | ||
} | ||
connection.dispose(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heliocliu this is a good example of a problem with our unlinked repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approved
…sitor pattern (#21379) Follow up from this comment - #21347 (comment) During summarization or attachments, both GC and summarize runs and they iterate over data stores and channel contexts during summarization. The logic to filter and validate is duplicated for both which makes it prone to get diverged. This PR updates the following set of function to use the [visitor](https://en.wikipedia.org/wiki/Visitor_pattern) pattern to iterate over data stores / channel contexts: - `summarize` and `getGCData`. - `getAttachSummary` and `getAttachGCData`. One logic change in this PR: - It updates `ChannelCollection::getAttachSummary` to use a visisted set to ensure that a node is only summarized oncen similar to `FluidDataStoreRuntime::getAttachSummary`. It earlier used the summary tree to do this. #8257
related to #8076