Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Core-Interface in client packages #8257

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

anthony-murphy
Copy link
Contributor

@anthony-murphy anthony-murphy commented Nov 15, 2021

related to #8076

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file labels Nov 15, 2021
@anthony-murphy anthony-murphy requested a review from a team as a code owner November 15, 2021 20:47
@github-actions github-actions bot removed the request for review from a team November 15, 2021 20:47
@github-actions github-actions bot added the public api change Changes to a public API label Nov 15, 2021
@@ -90,6 +90,8 @@ export const FileSnapshotWriterClassFactory: <TBase extends ReaderConstructor>(B
createBlob(file: ArrayBufferLike): Promise<api.ICreateBlobResponse>;
uploadSummaryWithContext(summary: api.ISummaryTree, context: ISummaryContext): Promise<string>;
downloadSummary(handle: api.ISummaryHandle): Promise<api.ISummaryTree>;
readonly disposed?: boolean | undefined;
Copy link
Contributor Author

@anthony-murphy anthony-murphy Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is due to @znewton change coming in #8083

} else {
connection.close();
}
connection.dispose();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this due to @scottn12 change #8185

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliocliu this is a good example of a problem with our unlinked repo

@anthony-murphy anthony-murphy self-assigned this Nov 16, 2021
@anthony-murphy anthony-murphy added this to the November 2021 milestone Nov 16, 2021
Copy link
Contributor

@DLehenbauer DLehenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approved

agarwal-navin added a commit that referenced this pull request Jun 14, 2024
…sitor pattern (#21379)

Follow up from this comment -
#21347 (comment)

During summarization or attachments, both GC and summarize runs and they
iterate over data stores and channel contexts during summarization. The
logic to filter and validate is duplicated for both which makes it prone
to get diverged.
This PR updates the following set of function to use the
[visitor](https://en.wikipedia.org/wiki/Visitor_pattern) pattern to
iterate over data stores / channel contexts:
- `summarize` and `getGCData`.
- `getAttachSummary` and `getAttachGCData`. 

One logic change in this PR:
- It updates `ChannelCollection::getAttachSummary` to use a visisted set
to ensure that a node is only summarized oncen similar to
`FluidDataStoreRuntime::getAttachSummary`. It earlier used the summary
tree to do this.

#8257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants