Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Introducing configuration #8496

Closed
wants to merge 24 commits into from
Closed

Draft: Introducing configuration #8496

wants to merge 24 commits into from

Conversation

anthony-murphy
Copy link
Contributor

related to #5921

anthony-murphy and others added 24 commits November 8, 2021 15:46
@anthony-murphy
initial config provider
95f333d
@anthony-murphy
initial config provider
3c0238c
@anthony-murphy
Merge branch 'config-provider' of https://github.com/anthony-murphy/F…
a744c44 
…luidFramework-1 into config-provider
@anthony-murphy
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
35df44a 
…to config-provider
@anthony-murphy
alpha
80baf21
@anthony-murphy
mixin with child logger
0cbebb1
@anthony-murphy
add debug logging
d31bc25
@anthony-murphy
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
1346d85 
…to config-provider
@anthony-murphy
improve typing
072350e
@andre4i
checkpoint
4e901a8
@andre4i
Add some tests
ee39887
@andre4i
Add more tests
5905c48
@andre4i
Override with breakglass
4d9e79b
@andre4i
Fix all instances of old API
6780154
@andre4i
Fix another usage of old API
feaf781
@andre4i
sessionStorage may not be defined
902f092
@andre4i
Merge branch 'main' into config-provider
2a246eb
@andre4i
Fix sessionstorage vs storage ref
f2c16fb
@andre4i
Fix undefined sessionstorage
cbe2925
@andre4i
moving some stuff around
48e6e19
@andre4i
SettingsProvider bridge
b9d9fb1
@andre4i
Some comments here and there
05fd94c
@andre4i
Merge branch 'main' into config-provider
d8f4c41
@andre4i
Fix region name
217b15a
@github-actions github-actions bot added area: driver Driver related issues area: loader Loader related issues labels Dec 8, 2021
@github-actions github-actions bot added area: odsp-driver area: runtime Runtime related issues public api change Changes to a public API labels Dec 8, 2021
@anthony-murphy anthony-murphy marked this pull request as ready for review December 8, 2021 01:21
@anthony-murphy anthony-murphy requested a review from a team as a code owner December 8, 2021 01:21
@anthony-murphy anthony-murphy marked this pull request as draft December 8, 2021 01:21
@msfluid-bot
Copy link
Collaborator

⯅ @fluid-example/bundle-size-tests: +19.78 KB
Metric NameBaseline SizeCompare SizeSize Diff
container.js 168.76 KB 178.1 KB ⯅ +9.34 KB
map.js 45.17 KB 45.38 KB ⯅ +216 Bytes
matrix.js 141.39 KB 141.6 KB ⯅ +218 Bytes
odspDriver.js 185.93 KB 195.53 KB ⯅ +9.6 KB
odspPrefetchSnapshot.js 41.3 KB 41.51 KB ⯅ +214 Bytes
sharedString.js 162.2 KB 162.41 KB ⯅ +218 Bytes
Total Size 777.45 KB 797.23 KB ⯅ +19.78 KB

Baseline commit: fb334bf

Generated by 🚫 dangerJS against 217b15a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladsud vladsud Awaiting requested review from vladsud

@jatgarg jatgarg Awaiting requested review from jatgarg

@tanviraumi tanviraumi Awaiting requested review from tanviraumi

@znewton znewton Awaiting requested review from znewton

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
area: driver Driver related issues area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-murphy @msfluid-bot @andre4i