r11s: add NGINX in front of docker-compose services #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
tanviraumi,
anthony-murphy,
GaryWilber and
hedasilv
hedasilv
approved these changes
Jan 25, 2022
pradeepvairamani
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8820 prompted me to add NGINX as a reverse-proxy in front of the local r11s services in Docker so that I could disable WebSockets at the proxy layer (comment out lines 39-40 in nginx.conf).
This more closely resembles how R11s works when deployed, and we could perhaps utilize this in the future to experiment with HTTP2 locally.