Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate noisy LastSummaryProposedHandleMismatch events #9107

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

pleath
Copy link
Contributor

@pleath pleath commented Feb 11, 2022

Don't bother logging LastSummaryProposedHandleMismatch when there is no lastSummaryProposalHandle to compare the new handle to, which is true if this instance of OdspSummaryUploadManager hasn't written a summary before. Only log on a positive mismatch.

@pleath pleath requested review from a team as code owners February 11, 2022 20:13
@pleath pleath linked an issue Feb 11, 2022 that may be closed by this pull request
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver labels Feb 11, 2022
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +41 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 382.05 KB 382.05 KB No change
containerRuntime.js 182.6 KB 182.6 KB No change
loader.js 158.62 KB 158.62 KB No change
map.js 50.64 KB 50.64 KB No change
matrix.js 145.46 KB 145.46 KB No change
odspDriver.js 193.96 KB 194 KB +41 Bytes
odspPrefetchSnapshot.js 45.37 KB 45.37 KB No change
sharedString.js 166.38 KB 166.38 KB No change
Total Size 1.33 MB 1.33 MB +41 Bytes

Baseline commit: 05f658e

Generated by 🚫 dangerJS against 18e6540

@pleath pleath merged commit 611d86d into main Feb 11, 2022
@pleath pleath deleted the user/pleath/proposed-handle-check branch February 11, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of times summarizer refreshes snapshot is too high
3 participants