Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MergeTree: Add stress for LocalReferences #9340
MergeTree: Add stress for LocalReferences #9340
Changes from 2 commits
386385a
163af72
82b8b3a
888970f
73377e6
4699c96
1164c37
a24c63b
11a903a
b3428c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment specifying the number made me curious enough to look. It seems to always happen to be enough but there's nothing directly protecting that in other tests. There should at least be a max check in the other tests that use it. Here it doesn't matter since it's 3, in which case do we really need to generate 69 strings? Not a big deal, especially since it's test code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code will fail with a null refer, which is probably good enough for test code localized to a single package. there are much more dangerous things in the test area, but none it will do anything besides break a test, which is easily caught and fixed