Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for gaps in the LocalReference array when packing segments #9565

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

pleath
Copy link
Contributor

@pleath pleath commented Mar 23, 2022

When Zamboni combines TextSegment's, it needs to update LocalReference's that refer to the segments. It wasn't doing this correctly in the case where, say, a reference is found at position 0, then some number of segments without references were appended, then a segment containing a reference was appended. The text corresponding to the segments without references wasn't accounted in the final segment. A gap needs to be introduced in the LocalReference array to make the references correct.

@pleath pleath requested a review from a team as a code owner March 23, 2022 21:08
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring labels Mar 23, 2022
@pleath pleath force-pushed the user/pleath/localrefs-scriptor branch from 31f299b to bc33e4d Compare March 23, 2022 21:10
@pleath pleath linked an issue Mar 23, 2022 that may be closed by this pull request
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Mar 23, 2022

@fluid-example/bundle-size-tests: +510 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 380.96 KB 381.12 KB +170 Bytes
containerRuntime.js 188.25 KB 188.25 KB No change
loader.js 158.72 KB 158.72 KB No change
map.js 203.34 KB 203.34 KB No change
matrix.js 290.68 KB 290.85 KB +170 Bytes
odspDriver.js 159.46 KB 159.46 KB No change
odspPrefetchSnapshot.js 46.03 KB 46.03 KB No change
sharedString.js 310.16 KB 310.32 KB +170 Bytes
Total Size 1.73 MB 1.73 MB +510 Bytes

Baseline commit: a622b1e

Generated by 🚫 dangerJS against 6c96512

@pleath pleath merged commit d081771 into main Mar 24, 2022
@pleath pleath deleted the user/pleath/localrefs-scriptor branch March 24, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intervals appear to change position after typing and syncing
3 participants